Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1132] Remove “don’t worry…” message from “Unlock Alerts” and add conditional rendering #2701

Closed

Conversation

use-tusk[bot]
Copy link
Contributor

@use-tusk use-tusk bot commented Sep 30, 2024

Updated ProFeatureWrapper component to remove the "Don't worry..." message from the "Unlock Alerts" popup. Added a new prop to control when the message should be displayed and added a conditional rendering logic for the message. Also, introduced a blue notification bar for the "Unlock Alerts" popup and ensured the message only shows up on the "Need more requests?" popup.


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review to address nits. If major changes are needed, retry the issue from the Tusk app with additional context.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs or issue to see more details.

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 5:59pm
helicone-bifrost 🛑 Canceled (Inspect) Sep 30, 2024 5:59pm
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 5:59pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant